Greasemonkey script - Conquer Club Turn Watch

[lancehoch]

Hey, my menu for Turn Watch disappeared. I finished all my games, then the next time I looked for it, it wasn't there. I uninstalled (and uninstalled all associated preferences) and reinstalled, but I still cant find the menu.

[chipv]

Hey, my menu for Turn Watch disappeared. I finished all my games, then the next time I looked for it, it wasn't there. I uninstalled (and uninstalled all associated preferences) and reinstalled, but I still cant find the menu.

Ok, there must be an error at startup. Click on Tools->Error console. There should be an error in bold somewhere.
Let me know what that is please.

[lancehoch]

Error: left is null
Source File: file:///C:/Documents%20and%20Settings/Lance/Application%20Data/Mozilla/Firefox/Profiles/ue78pvns.default/gm_scripts/conquer_club_turn_watch/conquer_club_turn_watch.user.js
Line: 206

I also have two from dice analyzer, not sure if those are relevant.

EDIT: Although, it is now showing my active games.

[chipv]

So is it working now or..?

[yeti_c]

"Left is null" can happen everynow and then - even BOB gets that a few times - I think technically it's a GM/FF issue - i.e. the left bar isn't finished loading before the script is attempted to be executed. - This *shouldn't* happen as GM is supposed to wait for the page to finish loading!

C.

[lancehoch]

It is working now. I think it was that I had no active games. Either that, or it was that I x'ed out all of the games from the list and it wanted an active game (not a waiting game) before it would reload.

[FreeMan10]

Hey, ChipV-

Just noticed an oddity. In game 3130531, when looking at the pop-up map, hovering over the green player only highlights Alcatraz. He's got several other territs, but that's the only one that TW finds.

TW 2.0.5
FF 3.0.1

Thanks again for the great tool and all your help a couple of weeks back,
FreeMan10

A quick edit: None of the continent bonuses that include Alcatraz highlight properly. It may be due to that territ's inability to attack (There's no escaping Alcatraz ). There may be an issue in parsing the XML on that one territ.

[lancehoch]

Hey chip. My Turn Watch seems to break if a game gets dropped and canceled. The current issue is that someone created a private game which I joined. The game did not fill up for a while and then disappeared; it is no longer on my waiting page. Turn Watch will not complete its scan now.

[chipv]

I'll take a look at these issues when I've cleared the current workload elsewhere.

[lancehoch]

Hey chip. My Turn Watch seems to break if a game gets dropped and canceled. The current issue is that someone created a private game which I joined. The game did not fill up for a while and then disappeared; it is no longer on my waiting page. Turn Watch will not complete its scan now.

Just wanted to bring this to your attention again. I think it has to do with fetching a game which no longer exists. Is there any way to check if the game exists before trying to add it to the menu? I reinstalled and got rid of the problem, but I am sure that it would not be too much to replicate. There was an associated error message, but I have cleared the console since that time.

[chipv]

RECENT SITE CHANGES REQUIRE CHANGES TO MOST SCRIPTS.

Thread is being locked until they're fixed.

[chipv]

2.0.6 available. Fixes the following bugs:

Hey, ChipV-

Just noticed an oddity. In game 3130531, when looking at the pop-up map, hovering over the green player only highlights Alcatraz. He's got several other territs, but that's the only one that TW finds.

TW 2.0.5
FF 3.0.1

Thanks again for the great tool and all your help a couple of weeks back,
FreeMan10

A quick edit: None of the continent bonuses that include Alcatraz highlight properly. It may be due to that territ's inability to attack (There's no escaping Alcatraz ). There may be an issue in parsing the XML on that one territ.

Hey chip. My Turn Watch seems to break if a game gets dropped and canceled. The current issue is that someone created a private game which I joined. The game did not fill up for a while and then disappeared; it is no longer on my waiting page. Turn Watch will not complete its scan now.

Sorry it took so long, very busy on other stuff but it is worth saying that these bug reports were outstanding. Helps us fix the problem in no time, thanks very much again.

[lancehoch]

Nice work chip, thanks for taking the time.

[yowzer14]

Chip:

One item for "Turn Watch". Just noticed that you neglected (on purpose?) to include the ?mode=next in the parsing.

On lines 1216-1217

Was

Code: Select all

        if(/player.php\?mode=find/.test(window.location.href) || /player.php\?mode=mygames/.test(window.location.href) ||
           /player.php\?submit=Search/.test(window.location.href)) {

New (to include the next page)

Code: Select all

        if(/player.php\?mode=find/.test(window.location.href) || /player.php\?mode=mygames/.test(window.location.href) ||
           /player.php\?submit=Search/.test(window.location.href) || /player.php\?mode=next/.test(window.location.href)) {

[chipv]

Neglected. Map Rank has it correct and it looks like there is another page neglected also as well as mode=next.

Thanks

[yowzer14]

Neglected. Map Rank has it correct and it looks like there is another page neglected also as well as mode=next.

Thanks

No probs...welcome.

[lancehoch]

Not sure if this has come up, but in my recent quads games, when it is a teammate's turn the notification pop up appears. The problem is that the text "Next Player The Fuzzy Penguin" appears about 4 times. I will get a screenshot the next time it happens.

[lancehoch]

Here is the image. Sorry it took so long.

[bigimg]http://i292.photobucket.com/albums/mm1/lanchoch/turnwatch.jpg[/bigimg]

[Boss_oss_ss]

Turn watch is causing me to not be able to take turns i can see all the buttons but not click them

[chipv]

Turn watch is causing me to not be able to take turns i can see all the buttons but not click them

Can you explain how you came to this conclusion, please?

[lancehoch]

chip, any ideas on that screenshot I posted?

[chipv]

chip, any ideas on that screenshot I posted?

Yeah it's a bug , been there for ages, possibly from day one. Never got round to fixing it as it didn't affect anything else apart
from the alert. I'll get round to it at some point.

[lancehoch]

chip, any ideas on that screenshot I posted?

Yeah it's a bug , been there for ages, possibly from day one. Never got round to fixing it as it didn't affect anything else apart
from the alert. I'll get round to it at some point.

No problem, I just wanted to make sure you were aware of it.

[Boss_oss_ss]

Turn watch is causing me to not be able to take turns i can see all the buttons but not click them

Can you explain how you came to this conclusion, please?

I dept disabling and enabling grease monkey scripts and i could only take my turns if Turnwatch is turned off!

[ppgangster]

Something else is wrong with turnwatch... (on firefox, on a Mac, everything installed - meaning all pluggins I found on this site)

minor bug. It's about the friends list when I want to send a message from my inbox. It comes all wrong.

Here is the link to the post

But if it is disabled, works fine and the display is back to normal!