manicman wrote:If I make a non agression alliance with someone and the condition to break it is a one turn warning then when I break it do I wait a turn and then they wait a turn, or do I wait a turn and then they get to attack immediately?
My answer to your question is yes.

The essence of the termination clause for this agreement is that the party receiving notice must receive the notice BEFORE the receiving party's turn starts. This is to allow the receiving party to prepare for the end of the agreement. This guarantees that the party receiving notice of termination will not be attacked before he is ready.
There are two ways to interpret the termination condition of the pact in your question. Your question anticipates the answer by giving both of the interpretations. We might call the first the conservative interpretation and the second the liberal interpretation. Both of them protect the party receiving notification.
For the sake of an example assume two players,
red and
green. Assume it's round 10.
Round 10:Game Chat:
Green: red, non-aggression pact with one-turn notice of termination?
Red: OK, agreed.
let's say it's red's turn first
Red honors the terms of the NAP on his turn.
Green honors the terms of the NAP on his turn.
Round 11:Red honors the term of the NAP on his turn.
Green would like to get out of the NAP at this point so he gives notice to red as follows:
Game Chat:
Green: red, I'm giving my one turn notice that the NAP is terminated.
Green: the NAP will be over at the start of round 13.
Green honors the NAP during his turn.
Round 12:Red has received his one-turn notice before this turn. He must honor the terms of the agreement during this turn.
Green honors the NAP in order to give red his one-turn notice.
Round 13:Red is free to attack green because he has received his one-turn mandated by the notice requirement (in round 12) and the NAP is terminated.
Green is free to attack because he gave his one-turn mandated by the notice requirement (in round 12) and the NAP is terminated.
Analysis of the conservative interpretation:1) Green gives notice during his turn in round 11. The NAP remains in effect during round 12 (the one-turn specified by the notice terms). Both parties honor the terms in round 12. At the beginning of round 13 the NAP is terminated and both players are no longer bound by it in any way.
2)
The effect of this type of one-turn notice is that the party who receives the notice gets one-turn (in this case round 12) during which the terms of the NAP are honored after the notice is received. In other words, this is red's one turn during which he can expect the terms of the NAP to be honored following the notification (which occurred in round 11).
============================================
Here's the liberal interpretation of the same scenario:
Round 10:Game Chat:
Green: red, non-aggression pact with notice of termination?
Red: OK, agreed.
let's say it's red's turn first
Red honors the terms of the NAP on his turn in round 10.
Green honors the NAP on his turn in round 10.
Round 11:Red honors the NAP on his turn in round 11.
Green would like to get out of the NAP at this point, so before green's turn ends he posts to game chat:
Game Chat:
Green: red, I'm giving notice that I'm terminating the NAP.
Green: the NAP is terminated at the start of your next turn (round 12).
During green's turn in round 11 he honors the terms of the NAP
Round 12:
Red reads the game chat containing the notice from green.
He takes his turn without any obligation to honor the terms of the NAP because it has been terminated by green with notice.
Green takes his turn, without any obligation to honor the NAP because it has been terminated with notice.
Analysis of the liberal interpretation:
1. The party terminating the NAP gives notice in game chat prior to the other party beginning his turn. The surest way to make sure you give notice before the other party's turn begins is to give that notice during your turn -- that guarantees that the other party sees the notice before the other's party can begin. This is the way I recommend.
It makes sense too. If you are about to end a NAP you know that during your turn, right? Presumably you will fortify during your turn to reinforce the border that was the subject of the NAP. This is the time when you should give notice.
2.
The player receiving the notice of termination receives the notice BEFORE his turn starts. He must be given notice before his turn starts. He can deploy his forces with the knowledge that the NAP is no longer in effect. Red can attack green at will.
The disadvantage of the conservative interpretation in this case is that there was essentially a "wasted turn" during which both parties knew the NAP was going to be terminated, but they couldn't attack each other. Unfortunately, all the other players in the game (non-parties) to the NAP also know it's going to be terminated.
The advantage of the liberal interpretation in this case is that there's a shorter period of time between when notice is given and when the parties can attack each other. There's less time for non-parties to react to the notification, but the parties themselves are adequately prepared for the termination.
The answer is that either interpretation could be correct which is why I always had green specify the actual round number when the pact would be terminated when he gave the termination notice. I think if you do this then nobody will complain and you can be considered to have honorably lived up to the terms of the agreement.