Hi, folks:
BOB continues to delight. Thank you for your great work on it!
I think I've found a minor bug in BOB. In some team games, there is sometime a rounding error with the team's "Strength" value in the "Statistics" section. The rounding error presents as a number with many decimal places of "99999" or "0000", either just greater than or just less than a number rounded to two decimal places.
The error only occurs for some values of player strength values. For instance in my present
Game 3378319, as of Round 6, player 3's Strength was 52.01, player 4's Strength was 34, and the Team 2 Strength was 86.00999999999999. This is just less than the correct sum of 86.01.
I believe that the problem is that the player strengths are rounded to two decimal places using a formula like
- Code: Select all
pl_Strength = Math.round( (...some forumla...) * 100 )/100;
but the team strength is done by simple addition:
- Code: Select all
teamStrength += pl_Strength;
and floating point numbers, being unable to represent 0.1 and 0.01 exactly, sometimes can't add the player strength exactly.
The simplest fix I found was to round off the teamStrength value with a statement like:
- Code: Select all
teamStrength = Math.round(teamStrength*100)/100;
I inserted this statement in two places. First, between lines 3492 and 3493, leading to code looking like:
- Code: Select all
if (LastTeamID != 0 )
{
teamStrength = Math.round(teamStrength*100)/100; //@@@ Rounding bug fix 2008/10/13
statsStr+= "<tr>" +
Second, between lines 3665 and (blank line) 3666, leading to code looking like:
- Code: Select all
if (isTeamGame())
{
pctArmies = Math.round(teamArmies*100/totalArmies);
pctCountries = Math.round(teamTerritories*100/totalCountries);
pctCalcCountries = Math.round(teamCalcedTerrs*100/totalCountries);
teamStrength = Math.round(teamStrength*100)/100; //@@@ Rounding bug fix 2008/10/13
curpid = 0;
nameStr = "Team " + teamID;
This fix was effective for me.
Bug found in Bob 4.6.3, running on FireFox 3.0.3 on a Mac OS 10.5.6 OS, on 2008/Oct/13.
